D20925: Also handle muted property on player

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Apr 30 20:16:24 BST 2019


broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Report a `Volume` of `0.0` for a muted player and set its `muted` property to whether `volume` is `0.0`

TEST PLAN
  Unfortunately there's no `Muted` property on MPris, so you cannot easily "restore" the previous volume, but that's an issue that affects every player, so when you click mute on a player and then adjust the volume in media controller it raises the volume from 0 rather than just working on the previous volume like the volume plasmoid would
  
  - Clicked mute on a video player, mpris reported zero, and UI reflected muted state by crossing out the volume icon on the player
  - Used wheel on media controller to change volume, media player became muted when volume hit 0.0

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D20925

AFFECTED FILES
  extension/content-script.js
  host/mprisplugin.cpp
  host/mprisplugin.h

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190430/b84afda6/attachment-0001.html>


More information about the Plasma-devel mailing list