D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

Tue Apr 30 17:45:25 BST 2019

kossebau added a comment.

  In D20896#458668 <https://phabricator.kde.org/D20896#458668>, @kossebau wrote:

  > @ngraham @filipf For the Visibility combobox, could you test if changing "ml" to "mi" in https://phabricator.kde.org/source/kdeplasma-addons/browse/master/applets/weather/weatherapplet.cpp$97 fixes things for you? Rather sure it does, but cannot create a diff currently.

  Okay, tested now myself, pretty sure this is the fix, and you ran into the bug because your locale != QLocale::MetricSystem :) So pushing fix directly now.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D20896

To: ngraham, #vdg, #plasma, kossebau, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190430/459ea6cf/attachment-0001.html>