D18394: Add OTP support for openconnect VPN

[Jan Grulich]

jgrulich added a comment.


  Sorry for the delay, I promise that I will start reviewing this more frequently so it gets merged just in time for Plasma  5.16 (we have 2 weeks).
  
  One more thing: When I open the "Token authentication" dialog, the "Token secret" label is not aligned with the text input
  
  Otherwise I think it looks good, but I didn't test it as I don't have time to configure an openconnect server.

INLINE COMMENTS

> openconnectauth.cpp:285
> +
> +        if (d->tokenMode == "manual" && !tokenSecret.isEmpty()) {
> +            ret = __openconnect_set_token_mode(d->vpninfo, OC_TOKEN_MODE_STOKEN, tokenSecret);

QStringLiteral("manual")

Same below.

> openconnectauth.cpp:288
> +        }
> +        else if (d->tokenMode =="stokenrc") {
> +            ret = __openconnect_set_token_mode(d->vpninfo, OC_TOKEN_MODE_STOKEN, NULL);

Coding style. The "else if" should be on the same line as the "}" bracket. Same below.

> openconnectprop.ui:181
> +        <property name="text">
> +         <string>Invalid certificates won't be acepted</string>
> +        </property>

Use same description NM uses in nm-connection-editor:
"Prevent user from manually accepting invalid certificates"

> openconnectwidget.cpp:120
> +    QVariant mode = d->tokenUi.cmbTokenMode->itemData(index);
> +    if (mode == "disabled") {
> +        d->tokenUi.leTokenSecret->setEnabled(false);

QStringLiteral("disabled")

Same below.

> openconnectwidget.cpp:124
> +    }
> +    else if (mode == "stokenrc") {
> +        d->tokenUi.leTokenSecret->setEnabled(false);

Coding style.  The "else if" should be on the same line as the "}" bracket. Same below.

REVISION DETAIL
  https://phabricator.kde.org/D18394

To: enriquem, jgrulich
Cc: pino, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190430/be166c27/attachment-0001.html>