D20900: Reject invalid keys

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> passworddialog.cpp:76
> +                m_connectionSettings->setting(NetworkManager::Setting::WirelessSecurity).staticCast<NetworkManager::WirelessSecuritySetting>();
> +        if (m_connectionSettings->connectionType() == NetworkManager::ConnectionSettings::Wireless
> +            && wirelessSecuritySetting) {

Last thing I would change is:

1. First check whether the connection type is NetworkManager::ConnectionSettings::Wireless
2. Then attempt to get WirelessSecuritySetting, because it's not necessary to do it for all the other connection types

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20900

To: McPain, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190430/d23e5816/attachment.html>