D20915: Don't abort when org.freedesktop.pulseaudio.module-group schema isn't installed

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Apr 30 10:33:34 BST 2019


broulik created this revision.
broulik added reviewers: Plasma, nicolasfella, drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Calling `g_settings_new_with_path` with a schema that isn't installed raises a `g_error` and aborts making the KCM crash on older PulseAudio versions.
  This basically copies what `g_settings_new_with_path` does internally but just prints a warning on console and carries on.

TEST PLAN
  Started the KCM on PulseAudio 11.1 (neon bionic), got an error on console, no longer crashed, had the module checkboxes disabled in settings

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D20915

AFFECTED FILES
  src/gsettingsitem.cpp
  src/gsettingsitem.h

To: broulik, #plasma, nicolasfella, drosca
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190430/66caf9bf/attachment-0001.html>


More information about the Plasma-devel mailing list