D20859: Crash in sddmthemeinstaller invalid use of errorString

[John Gehrig]

johngehrig added a comment.


  @anthonyfieroni Yes, I think there also an issue with KAuth here. This machine never gets to the auth prompt, which works fine on another machine.
  
  I don't think "jobs" is deleting itself, otherwise we would segfault on "jobs->error()". No?
  
  @davidedmundson Just so that I understand... You are saying "this" (parent window of dialog) is deleted out from under KMessageBox while it is in a waiting state?
  
  I don't think that is the problem, but I will investigate and report back... From what I have observed, we segfault on "job->errorString()".
  
  A simple case which should also crash:
  
    + QString errMessage = job->error();
    -  KMessageBox::sorry(nullptr, i18n("Unable to install theme"), job->errorString());
    - qWarning() << job->error() << job->errorString();
  
  How would flipping the order help with the crash? Although logging first, then displaying the dialog seems like a good improvement.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D20859

To: johngehrig, ngraham, davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190429/82f4df0b/attachment-0001.html>