D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

Nathaniel Graham noreply at phabricator.kde.org
Mon Apr 29 16:55:20 BST 2019


ngraham added inline comments.

INLINE COMMENTS

> kossebau wrote in ConfigWeatherStation.qml:85
> While I see this: what are all those "-symbolic" variants and when would one use it? Is that documented anywhere? I expeted something on hig.kde.org, but found nothing.

The `-symbolic` suffix means "this icon is always supposed to be monochrome". However in this case I used the -symbolic version simply because there was no non-symbolic version in Breeze icons. However it's not semantically incorrect to use that here anyway since buttons are generally only supposed to have monochrome icons in the first place.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D20896

To: ngraham, #vdg, #plasma, kossebau
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190429/3fab0eb7/attachment.html>


More information about the Plasma-devel mailing list