D20899: [User Switcher] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> configGeneral.qml:86
> +        QtControls.ButtonGroup.group: layoutGroup
> +        text: i18nc("@option:radio", "Picture")
> +        checked: !cfg_showName && cfg_showFace

Maybe we could say "User picture" just to be more precise?

> configGeneral.qml:100
> +        QtControls.ButtonGroup.group: layoutGroup
> +        text: i18nc("@option:radio", "Name and picture")
> +        checked: cfg_showName && cfg_showFace

Ditto.

> configGeneral.qml:117
> +    QtControls.CheckBox {
> +        id: showTechnicalInfoCheck
> +

Not related to your changes, but can you help me out lol, what does this option do? I'm not seeing anything happening when I turn it on or off.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D20899

To: ngraham, #vdg, #plasma
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190429/1bf33b6f/attachment.html>