D20878: [containments/desktop] Port desktop settings pages to QQC2+Kirigami FormLayout and modernize UI

[Filip Fila]

filipf accepted this revision.
filipf added a comment.


  Works fine and looks good to me. This is probably a style issue, but it should be noted that these buttons shouldn't stay highlighted after they're pressed:
  
  F6798674: image.png <https://phabricator.kde.org/F6798674>

INLINE COMMENTS

> ConfigLocation.qml:199
>  
>              Item {
>                  width: units.largeSpacing

Personally I don't think we need this indent as the enabled property already gives a clue what the text field is related to, but it's not particularly important one way or another.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  containments-desktop-port-desktop-settings-pages-to-qqc2-plus-kirigami-formlayout-and-modernize-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20878

To: GB_2, #plasma, #vdg, davidedmundson, filipf
Cc: filipf, davidedmundson, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190428/22efc4e2/attachment-0001.html>