D20871: Don't delete profiles and ports on update
Nicolas Fella
noreply at phabricator.kde.org
Sat Apr 27 17:20:56 BST 2019
nicolasfella created this revision.
nicolasfella added a reviewer: drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.
REVISION SUMMARY
When a profile/port is updated the old code deletes all objects and creates new ones. This breaks connections set on the objects.
In Card the return type of ports() is changed from QVector<Port*> to QVector<CardPort*>. This probably breaks API/ABI, but the only current user (KDE Connect) is not affected and we don't give ABI guarantees.
REPOSITORY
R994 Pulseaudio Qt Bindings
BRANCH
keep
REVISION DETAIL
https://phabricator.kde.org/D20871
AFFECTED FILES
CMakeLists.txt
src/card.cpp
src/card.h
src/card_p.h
src/device.cpp
src/device_p.h
To: nicolasfella, drosca
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190427/0e7a2746/attachment.html>
More information about the Plasma-devel
mailing list