D20846: [Task Manager] Don't show redundant "Actions" header in context menu with nothing but actions in it

Nathaniel Graham noreply at phabricator.kde.org
Fri Apr 26 16:10:17 BST 2019


ngraham created this revision.
ngraham added reviewers: broulik, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Previously, the Actions header was always shown, even when the context menu
  consisted of nothing but actions. This is unnecessary since a menu's normal state is
  to show nothing but actions.
  
  With this patch, the Actions header is only shown for context menus that have
  more than one section.

TEST PLAN
  Context menu with only actions: F6795048: All actions.png <https://phabricator.kde.org/F6795048>
  
  Context menu with nore than just actions: F6795049: More than just actions.png <https://phabricator.kde.org/F6795049>

REPOSITORY
  R119 Plasma Desktop

BRANCH
  dont-show-redundant-action-header (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20846

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

To: ngraham, broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190426/5cdf6f3b/attachment.html>


More information about the Plasma-devel mailing list