D20829: [Calendar] Port settings window to QQC2+Kirigami FormLayout and modernize UI

Filip Fila noreply at phabricator.kde.org
Thu Apr 25 21:11:16 BST 2019


filipf accepted this revision.
filipf added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> configGeneral.qml:27
>      id: generalPage
>      
> +    anchors.left: parent.left

trailing space

> configGeneral.qml:50
> +    QtControls.RadioButton {
> +        Kirigami.FormData.label: i18nc("What information is shown in the calendar icon", "Compact version:")
> +

Compact version is maybe a bit vague, but I can't think of anything better honestly.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  modernize-calendar-widget-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20829

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190425/51615803/attachment.html>


More information about the Plasma-devel mailing list