D20804: RFC: Try getting the X keyboard grab multiple times

[David Edmundson]

davidedmundson created this revision.
davidedmundson added reviewers: Plasma, KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Right now when the screen locker starts it tries to grab the keyboard on
  X. This fails if any other application has grabbed the keyboard.
  
  In these situations the screen simply doesn't lock which is a pretty
  rubbish state.
  
  This can't be realistically fixed properly on X, on wayland it's a
  non-issue.
  
  However, we can minimise the occasions when this occurs.
  
  This patch emits a signal before locking and then tries the lack
  multiple times. Clients can listen for this event and release their
  keyboard grabs.

TEST PLAN
  Wrote relevant matching kwin patch to close effects
  "sleep 5 ; loginctl lock-session" whilst a desktop effect was active still locked the session

REPOSITORY
  R133 KScreenLocker

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20804

AFFECTED FILES
  dbus/org.kde.screensaver.xml
  interface.cpp
  interface.h
  ksldapp.cpp
  ksldapp.h

To: davidedmundson, #plasma, #kwin
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190425/3e75da92/attachment.html>