D20736: Limit thumbnail size

Fabian Vogt noreply at phabricator.kde.org
Mon Apr 22 20:32:00 BST 2019


fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> mprisplugin.cpp:493
>  
> -        if (!biggest.isValid() || (actualSize.width() >= biggest.width() && actualSize.height() >= biggest.height())) {
> +        if (!biggest.isValid() ||
> +                (actualSize.width() >= biggest.width() && actualSize.height() >= biggest.height()

AFAICT this will not work as expected in cases such as 1920x1080 followed by 256x256.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D20736

To: broulik, #plasma, fvogt
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190422/43d8738c/attachment.html>


More information about the Plasma-devel mailing list