D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

Nathaniel Graham noreply at phabricator.kde.org
Fri Apr 19 15:39:04 BST 2019


ngraham added inline comments.

INLINE COMMENTS

> batterymonitor.qml:142
> +        if (batterymonitor.kcmEnergyInformationAuthorized) {
> +            plasmoid.setAction("energyinformationkcm", i18n("&Energy Information..."), "battery");
> +        }

Generally we start menu items with action verbs. And in this case we don't need ellipsis because no further input from the user is required as a part of the action. See https://hig.kde.org/style/writing/labels.html#using-ellipses-in-labels

So for this string, I would recommend "Show Energy Information"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20533

To: meven, #plasma, ngraham, broulik, #vdg
Cc: abetts, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190419/3cfad936/attachment.html>


More information about the Plasma-devel mailing list