D20661: [MPRIS Data Engine] Avoid blocking calls when changing volume

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Apr 18 13:46:13 BST 2019


broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Avoids plasmashell freezing when the player app is unresponsive or has a broken MPRIS implementation

TEST PLAN
  `kill -SIGSTOP `pidof vlc`, wheeled the tray icon, plasmashell didn't freeze anymore.
  Quickly changing volume still works (hence setting the new value in the dataengine right away)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20661

AFFECTED FILES
  dataengines/mpris2/playercontrol.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190418/51a1aa3c/attachment.html>


More information about the Plasma-devel mailing list