D17410: Add alternatives button to applet configuration in panel edit mode

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Apr 17 14:41:57 BST 2019


broulik requested changes to this revision.
broulik added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ConfigOverlay.qml:227
>  
> +        currentApplet.applet.prepareContextualActions();
>          handle.x = currentApplet.x;

This is never triggered when you just move the mouse over, you probably want to do that in the `onVisualParentChanged` handler below

Ideally this was all done using proper bindings instead of imperative code, though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson, broulik
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, cblack, arvidhansson, ian, jguidon, hannahk, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190417/e5fcb5d0/attachment-0001.html>


More information about the Plasma-devel mailing list