D19011: Thunderbolt KCM and KDED module

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> kded_bolt.h:34
> +class KNotification;
> +namespace Bolt {
> +class Device;

Coding style nitpick:

> Function implementations, class, struct and namespace declarations always have the opening brace on the start of a line.

> dbushelper.cpp:35
> +
> +} // namespace
> +

Nitpick: "// anonymous namespace" is more verbose. :-)

> device.cpp:95
> +{
> +    const auto val = mInterface->type();
> +    return val.isEmpty() ? Type::Unknown : typeFromString(val);

Coding style nitpick(?): Maybe it's a matter of taste, but is it a good idea to use `auto` here?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19011

To: dvratil, #vdg, #plasma
Cc: zzag, GB_2, knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190415/606e77f9/attachment.html>