D20490: Rewrite notifications dataengine to work with libnotificationmanager

Kai Uwe Broulik noreply at phabricator.kde.org
Fri Apr 12 12:52:24 BST 2019


broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Keeps it mostly working for compatibility.
  
  The grouping stuff in there has been dropped, the old plasmoid should otherwise continue to work as normal.
  The dataengine inhibition feature used by plasma-nm is defunct now, not sure how this could be implemented in the new system as the `Server` knows nothing about inhibitions, it's all filtered in the models.

TEST PLAN
  D20265 <https://phabricator.kde.org/D20265>
  
  Tried with old plasmoid, got notifications with title and text and images. Also tested the timer plasmoid and it successfully showed a "timer finished" notification with the new system

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20490

AFFECTED FILES
  dataengines/notifications/CMakeLists.txt
  dataengines/notifications/notificationaction.cpp
  dataengines/notifications/notifications_test.cpp
  dataengines/notifications/notificationsanitizer.cpp
  dataengines/notifications/notificationsanitizer.h
  dataengines/notifications/notificationsengine.cpp
  dataengines/notifications/notificationsengine.h
  dataengines/notifications/org.freedesktop.Notifications.xml

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190412/6686a5e3/attachment.html>


More information about the Plasma-devel mailing list