D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Roman Gilg]

romangg added a comment.


  In D20186#444431 <https://phabricator.kde.org/D20186#444431>, @atulbi wrote:
  
  > In D20186#443596 <https://phabricator.kde.org/D20186#443596>, @romangg wrote:
  >
  > > Nice work. Most of the stuff in libinputtouchpad.cpp and its header file are copy-paste from the Wayland backend. It would make sense to have a new abstract parent class such that the code is shared.
  >
  >
  > Initially, I also wanted to implement it that way, but it'll mess up existing code, and especially because LibinputTouchpad class already extends XlibTouchpad class. Or split out the common parts into a helper-class.
  
  
  Can it multi-inherit?
  
  > I wanted to have minimal changes to existing code.
  
  Make a two patch series: first patch would be creating the parent class and let current Wayland backend inherit it. Second patch would be creating X11/libinput child class.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190412/4646280c/attachment.html>