D20407: [Folder View] Improve label crispness

Nathaniel Graham noreply at phabricator.kde.org
Tue Apr 9 16:36:43 BST 2019


ngraham added a comment.


  In D20407#446723 <https://phabricator.kde.org/D20407#446723>, @fvogt wrote:
  
  > It was actually discovered by openQA as a regression introduced yesterday: https://openqa.opensuse.org/tests/902646#step/finish_desktop/8 (bad) vs https://openqa.opensuse.org/tests/902110#step/finish_desktop/2 (good)
  >  Probably a side effect of the label width change(s).
  >
  > This diff might not be entirely correct as the rounding error can accumulate across all columns, thus making the width of all cells combined greater than the container's width.
  
  
  I just added a ton of items to the desktop and tested with all combinations of icon sizes and label widths; in no case did the content ever overflow the container. I didn't see any other visual artifacts, either.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-folder-view-label-crispness (branched from Plasma/5.12)

REVISION DETAIL
  https://phabricator.kde.org/D20407

To: ngraham, fvogt, #plasma, hein, filipf
Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190409/0e5b6f88/attachment-0001.html>


More information about the Plasma-devel mailing list