D20112: [analog-clock] Allow themes to define hand shadow offset & hand rot center

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 55777.
kossebau added a comment.


  Instead of using the size of a hint to define the rotation center of a hand
  shape, use the relative position of the (center of) hint.
  This allows to define rotation centers outside of the hand element, like
  useful for all those themes which use hands shapes that do not cover the
  clock center.
  It also is visually for the designer more logically to place e.g. a circle
  as rotation center hint exactly where the center of rotation is for a hand,
  instead of the abstract offset shape hint.
  And the relative positioning also solves the issue of having the rotation
  center directly at the border, where before the offset hint was not possibly
  due to a size of 0 in one dimension resulting in the hint not being visual
  and thus not propagated by QSvgRenderer/Plasma::Svg.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20112?vs=55026&id=55777

BRANCH
  fixclockshadowhandcenter

REVISION DETAIL
  https://phabricator.kde.org/D20112

AFFECTED FILES
  applets/analog-clock/contents/ui/Hand.qml
  applets/analog-clock/contents/ui/analogclock.qml

To: kossebau, #plasma, #vdg, mart, davidedmundson, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190408/8be27395/attachment.html>