D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Is it really necessary to copy `urlinfo.h` here? Wouldn't be enough to just create a static function and put the URL parsing logic there?

INLINE COMMENTS

> urlinfo.h:45-52
> +        if (QFile::exists(path)) {
> +            /**
> +             * create absolute file path, we will e.g. pass this over dbus to other processes
> +             * and then we are done, no cursor can be detected here!
> +             */
> +            url = QUrl::fromLocalFile(QDir::current().absoluteFilePath(path));
> +            return;

Why doesn't it parse the URL if the file already exists?

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D18296

To: arrowd, #plasma, #ktexteditor, broulik, #frameworks, pino, cfeck, dfaure, elvisangelaccio
Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190406/04f4365b/attachment.html>