D20198: Don't lose list position after installing KNS cursor themes

Dan Leinir Turthra Jensen noreply at phabricator.kde.org
Fri Apr 5 08:29:11 BST 2019


leinir marked 2 inline comments as done.
leinir added inline comments.

INLINE COMMENTS

> apol wrote in kcmcursortheme.cpp:468
> Use splitRef if you're just taking the last one.

Quite - still need to convert that last to a string later, but less string creation's good :) Kind of a microoptimisation, given we're dealing with disk io as well, but it doesn't hurt readability anyway, so, yup :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20198

To: leinir, #plasma, ngraham, broulik
Cc: apol, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190405/f05c134e/attachment.html>


More information about the Plasma-devel mailing list