D20237: Port to new KWorkspace API

[David Edmundson]

davidedmundson added a comment.


  > Personally I tend to prefer just readable, explicit code for simple cases.
  
  Now the timing of my comment becomes awkward :/

INLINE COMMENTS

> systementry.cpp:86
> +{
> +    ++s_instanceCount;
>  

you increment this on every refresh, only decrement once in the destructor

refresh is potentially called multiple times in the object's lifespan

refresh is called from the constructor so we may as well do it all there

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20237

To: hein, #plasma, davidedmundson
Cc: broulik, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190404/6413b645/attachment.html>