D19822: [Task Manager] Toggle mute when the audio indicator is clicked

Eike Hein noreply at phabricator.kde.org
Tue Apr 2 22:26:12 BST 2019


hein added a comment.


  About the icon issue, IconItem by default uses the icon theme overlay from the Plasma theme, Kirigami.Icon will use the regular Plasma icons. That's kind of tricky - with Breeze we could totally make them match, but other Plasma themes would have issues.
  
  A long time ago I suggested that the overlay shouldn't be put into IconItem in this way, and instead it should be something like IconItem { source: OverlayIcon {} } to factor out the overlay stuff and keep IconItem generic. I wish we had that now, then it'd just work with Kirigami.Icon.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, hein
Cc: mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190402/3c9bb58d/attachment.html>


More information about the Plasma-devel mailing list