D20213: [kcolorschemeeditor] Use config path instead of searching again

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Apr 2 21:22:52 BST 2019


broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `m_schemeName` is the translated scheme name which may not match the file name.
  Since the config is always opened with an absolute path, we can just use the config's name.
  
  BUG: 399951

TEST PLAN
  I'll try putting that into 5.15 (but gonna be tough since the color kcm rewrite happened)
  
  - Ran `kcolorschemeeditor "BreezeHighContrast"` tried to upload, it got the correct `/usr/share/color-schemes/BreezeHighContrast.colors` path
  - Changed the scheme, saved it under a different name, tried to upload, it got the correct `~/.local/share/color-schemes/NewScheme.colors` path

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20213

AFFECTED FILES
  kcms/colors/editor/scmeditordialog.cpp

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190402/2a5c59f4/attachment-0001.html>


More information about the Plasma-devel mailing list