D20205: initialize the kcolorscheme at the first app start

Marco Martin noreply at phabricator.kde.org
Tue Apr 2 15:58:39 BST 2019


mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  when an app starts when there isn't a kdeglobals yet, it reads from
  the color theme defined in the look&feel package, but it did build only the
  QPalette of the application. any application using KColorScheme directly failed to
  get the proper color at startup (e.g. plasmashell, but also any app needing a color present in kcolorscheme but not in qpaletter, like activetext, negativetext etc)
  
  at the first start, copy over the colors from the scheme file to kdeglobals (same code of the kcm)
  that code is not cheap, but should be executed exactly once at the startup of the first app on an empty session

TEST PLAN
  started plasma with breezedark as lnf as the only key in /etc/xdg/kdeglobals, plasmashell gets the proper breeze dark colors now

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  phab/initializeColors

REVISION DETAIL
  https://phabricator.kde.org/D20205

AFFECTED FILES
  CMakeLists.txt
  src/platformtheme/khintssettings.cpp
  src/platformtheme/khintssettings.h

To: mart, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190402/5735ed18/attachment-0001.html>


More information about the Plasma-devel mailing list