D20161: Fix showing update notification
Kai Uwe Broulik
noreply at phabricator.kde.org
Mon Apr 1 11:21:19 BST 2019
broulik created this revision.
broulik added reviewers: Plasma, Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Updates variables first before checking `state()` which depends on them
TEST PLAN
- I now get a "updates available" notification on login again
I would suggest to add a unittest to the notifier as this thing seems to break every other release and not telling people about updates is bad
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D20161
AFFECTED FILES
notifier/DiscoverNotifier.cpp
To: broulik, #plasma, #discover_software_store
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190401/1da14f69/attachment.html>
More information about the Plasma-devel
mailing list