D15855: Port Kickoff to shared view component using single-MouseArea pattern

Eike Hein noreply at phabricator.kde.org
Sun Sep 30 14:16:30 BST 2018


hein created this revision.
hein added a reviewer: Plasma.
Herald added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  This:
  
  - Moves MouseArea out of the item delegate and uses a single MouseArea per view.
  - Ports all the pages to using a shared view component.
  
  Aside from saving a lot of QObjects, using a single MouseArea also
  has the advantage that MouseArea.positionChanged isn't fired when
  QQuickWindow synthesizes a hover event per frame, unlike MouseArea
  .containsMouse. This fixes a user-reported bug in the search page,
  and the same pattern is used by various other UIs we have for
  similar reasons.
  
  BUG:397693

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15855

AFFECTED FILES
  applets/kickoff/package/contents/ui/ApplicationsView.qml
  applets/kickoff/package/contents/ui/BaseView.qml
  applets/kickoff/package/contents/ui/Breadcrumb.qml
  applets/kickoff/package/contents/ui/FavoritesView.qml
  applets/kickoff/package/contents/ui/KickoffItem.qml
  applets/kickoff/package/contents/ui/SearchView.qml

To: hein, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180930/88bbab98/attachment.html>


More information about the Plasma-devel mailing list