D15815: Remove expensive blocking call on plasmashell startup
David Edmundson
noreply at phabricator.kde.org
Fri Sep 28 15:03:36 BST 2018
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
QDBusInterface is a blocking call that calls introspect. We don't need
to introspect.
As this is called on startup this call starts kuiserver, which means
plasma is blocked whilst a whole process spawns, this is a lot worse
than just a regular, ~100ms on my system
Also using the generated versions is generally neater to read.
TEST PLAN
Restarted plasmashell
Copied a file
Still had a spinny wheel
Q_DBUS_BLOCKING_CALL_MAIN_THREAD_WARNING_MS=0 doesn't list kuiserver
REPOSITORY
R120 Plasma Workspace
BRANCH
kuiserver_startup
REVISION DETAIL
https://phabricator.kde.org/D15815
AFFECTED FILES
dataengines/applicationjobs/CMakeLists.txt
dataengines/applicationjobs/kuiserverengine.cpp
To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180928/fda98e5b/attachment.html>
More information about the Plasma-devel
mailing list