D15333: Group Widget + Color Picker = Widget Out Of Bounds

[David Edmundson]

davidedmundson added a comment.


  Commits really benefit from a bit more description. Reviewers don't have the same context you had in your head when you wrote it.

INLINE COMMENTS

> main.qml:111
>      Plasmoid.compactRepresentation: Grid {
> -        readonly property int buttonSize: root.isVertical ? width : height
> +        readonly property int buttonSize: root.isVertical ? Math.min(width, (height * 2) + spacer.height) : Math.min(height, (width - spacer.width) / 2)
>  

Please explain the rationale behind this.

Especially the spacer.width being divided by 2 in the second part of the statement.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D15333

To: McPain, #plasma, ngraham
Cc: davidedmundson, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180927/6dcde861/attachment.html>