D15776: Show the preferred resolution on the combo box

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Code is neater. I like that.
  
  Don't have an opinion on the icon, maybe tag VDG.

INLINE COMMENTS

> resolutionslider.cpp:71
> +            mComboBox->addItem(icon, Utils::sizeToString(size));
> +            if (isCurrentMode || isPreferredMode) {
> +                mComboBox->setCurrentIndex(mComboBox->count() - 1);

I know you're not changing this, but this is rather broken.

You might have only a current mode or a preferred mode or both.

If you have both which one ends up selected by default is effectively arbitrary based on insertion order. (would require a monitor with a preferred mode that's smaller than the mode the user chose...but could happen I think?)

REPOSITORY
  R104 KScreen

BRANCH
  preferredkcm

REVISION DETAIL
  https://phabricator.kde.org/D15776

To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180926/a7f35e15/attachment-0001.html>