D15724: Wait for duration to be known before registering player

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> content-script.js:106
> +// When a player has no duration yet, we'll wait for it becoming known
> +// to determin whether to ignore it (short sound) or make it active
> +var pendingActivePlayer;

Missing e

> content-script.js:326
> +        // Deferred active due to unknown duration
> +        if (pendingActivePlayer && pendingActivePlayer == player) {
> +            setPlayerActive(pendingActivePlayer);

Is the `pendingActivePlayer` check necessary here?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D15724

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180924/a0fa7822/attachment.html>