D15637: Make DBusMenu work correctly with dynamically generated menus

[Igor Poboiko]

poboiko added a comment.


  > Can this potentially throw off the order of items or cause items to be removed that got inserted previously (ID clash?)?
  
  As far as I can see, it should not be the case: those two operations should be totally interchangeable.
  Both "insert/update" and "remove" actions are based on `rootItem.children` (which contains new layout of menu). Menu items that are inside it got updated, those who are not - got removed.
  
  > I can see the menu sometimes flickering showing that it briefly has more actions than it used to be. Reproducible in Krita's "Window" menu when using title bar menu button and interacting with the menu. After a while it also crashes.
  
  Thanks for the testing! 
  By "crashing" you mean literally application crashing or just menu gets closed? I was able to reproduce it (the second option) on LyX with title bar menu button; apparently, its behavior is somewhat different from the plasma applet. Will look into it.
  
  > Perhaps we should could do this only if the menu would become empty when removing the actions?
  
  We can. But my wild guess is that there will be probably also some flickering, but the other way around (i.e. briefly show it has fewer actions).
  Actually, I don't see how we can avoid it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15637

To: poboiko, #plasma, broulik, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180921/1d683377/attachment.html>