D15616: [Comic] Handle error state correctly

[Anthony Fieroni]

anthonyfieroni created this revision.
anthonyfieroni added reviewers: davidedmundson, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
anthonyfieroni requested review of this revision.

REVISION SUMMARY
  This happen really rare, i've used comic applet on my desktop about years, but in such cases dataUpdated is not called and busy indicator *burns* cpu. So i provide possible fix in comic provider, data engine, when redirection is needed error timer is not restarted in such case error is never handle properly. But *every* case i made a more aggressive solution, a timer in comic applet, if in 3 minutes dataUpdated isn't called it just force disconnect engine from source and stops indicator.
  
  CCBUG: 363292

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D15616

AFFECTED FILES
  applets/comic/comic.cpp
  applets/comic/comic.h
  dataengines/comic/comicprovider.cpp

To: anthonyfieroni, davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180920/797ca630/attachment.html>