D15613: [Hotplug Engine] Update actions at runtime and listen for added/removed

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Sep 20 09:57:13 BST 2018


apol added a comment.


  Sorry, very naif review.

INLINE COMMENTS

> hotplugengine.cpp:152
>                  Plasma::DataEngine::Data data;
>                  data.insert(QStringLiteral("predicateFiles"), predicates);
> +                data.insert(QStringLiteral("actions"), actionsForPredicates(predicates));

Don't we need to pass the icon and emblems here too?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15613

To: broulik, #plasma
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180920/953568cb/attachment.html>


More information about the Plasma-devel mailing list