D15521: Add validator for lists of IP addressesAdded as separate review per comment from Pino onreview D15093. This code will not compile withoutthe updated code in review D15520. Also includesunit test.

Bruce Anderson noreply at phabricator.kde.org
Mon Sep 17 07:17:32 BST 2018


andersonbruce marked 3 inline comments as done.
andersonbruce added inline comments.

INLINE COMMENTS

> jgrulich wrote in CMakeLists.txt:92
> I'm sure you don't need to add all these and why did you remove PUBLIC and PRIVATE keywords?

Damn, copied the wrong file. Sorry about that.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15521

To: andersonbruce, jgrulich, pino
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180917/dae448f9/attachment.html>


More information about the Plasma-devel mailing list