D14426: [Folder View] Create KFilePlacesModel only when needed and listen for changes
Kai Uwe Broulik
noreply at phabricator.kde.org
Mon Sep 10 09:08:37 BST 2018
broulik updated this revision to Diff 41318.
broulik edited the summary of this revision.
broulik added a comment.
- Make `KFilePlacesModel` `static` and ref-counted
For simplicify the ref count is increased/decreased in the constructor and not depending on whether the model is actually used, e.g. when user changes setting from default display label to something else. This would make the patch super complicated otherwise. The model is then only not loaded again on next startup.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14426?vs=38587&id=41318
REVISION DETAIL
https://phabricator.kde.org/D14426
AFFECTED FILES
containments/desktop/plugins/folder/labelgenerator.cpp
containments/desktop/plugins/folder/labelgenerator.h
To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180910/54ee6563/attachment.html>
More information about the Plasma-devel
mailing list