D15391: [Bookmarks Runner] Fix cleanup of favicon directory

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sun Sep 9 23:52:17 BST 2018


bruns created this revision.
bruns added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  QDir.entryInfoList(NoDotAndDotDot) always returns an empty list, as it
  requires one of QDir::Files, QDir::Dirs or QDir::Drives or any
  combination thereof.
  
  Instead of implementing it manually, use QDir::removeRecursively().

TEST PLAN
  Watch ~/.cache/krunner/
  When krunner is closed, KRunner-Favicons-firefox-default should
  be emptied and deleted.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  favicon_dir_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D15391

AFFECTED FILES
  runners/bookmarks/faviconfromblob.cpp

To: bruns, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180909/2de02e0c/attachment.html>


More information about the Plasma-devel mailing list