D15356: [Bookmarks Runner] Filter out empty urls, simplify, fix comment

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sat Sep 8 20:16:52 BST 2018


bruns created this revision.
bruns added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Bookmarks may have no title, the user is free to delete it when creating
  a bookmark.
  A bookmark without URL would be useless (there were nothing to refer to),
  so ignore any bookmark with an empty URL.
  Simplify check for Firefox specific "place:" URLs.

TEST PLAN
  Search for "Recent" or "place"
  "Recent Tags" is still filtered out

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15356

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: bruns, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180908/4c74c673/attachment.html>


More information about the Plasma-devel mailing list