D15305: KRunner: remove no longer existant and unused column from SQL query

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Sep 6 02:57:31 BST 2018


bruns created this revision.
bruns added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The favicon_id is not used in the query results, and may not even exist
  when the places db has been created with FF 58 or later. In case the
  column does not exist the query fails completely.
  
  BUG: 398305

TEST PLAN
  1. Create a new FF profile
  2. Add some bookmarks
  3. Do some queries

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15305

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: bruns, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180906/395759ac/attachment.html>


More information about the Plasma-devel mailing list