D15289: Use lambda instead of QSignalMapper

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Sep 5 12:03:39 BST 2018


broulik added inline comments.

INLINE COMMENTS

> ksysguardprocesslist.h:49
>   */
>  class Q_DECL_EXPORT KSysGuardProcessList : public QWidget
>  {

That class is exported, so changing method signatures will be ABI-incompatible. Not sure how many guarantees we give for libksysguard but I would still prefer to keep breakages to a minimum.

You could just keep the `qobject_cast`

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D15289

To: volkov, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180905/c519a498/attachment.html>


More information about the Plasma-devel mailing list