D15268: [Folder View] Use KIO::PreviewJob::defaultPlugins() for default plugins
Kai Uwe Broulik
noreply at phabricator.kde.org
Tue Sep 4 15:32:49 BST 2018
broulik created this revision.
broulik added reviewers: Plasma, VDG, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Rather than a hardcoded list of only two thumbnailers.
All of this is done under the hood so the QML part doesn't need to be changed.
This is the same behavior as Dolphin uses, when the list of thumbnailers is empty, the default set (which includes all thumbnailers except textthumbs) is used.
TEST PLAN
Before
F6234921: Screenshot_20180904_163023.png <https://phabricator.kde.org/F6234921>
After
F6234922: Screenshot_20180904_163036.png <https://phabricator.kde.org/F6234922>
- Verified that all the thumbnails are shown
- Verified that the previewer config dialog has the correct plugins checked
- Verified that changing the previewer config updates the thumbnails and has the setting stored, execpt when the default set of previews is enabled, nothing is stored so that when `defaultPlugins` would change, it is picked up automatically
I don't exactly know why the `ttf` thumbnail looks different from Dolphin where it is just a couple of letters instead of a full sentence
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D15268
AFFECTED FILES
containments/desktop/package/contents/config/main.xml
containments/desktop/plugins/folder/foldermodel.cpp
containments/desktop/plugins/folder/foldermodel.h
containments/desktop/plugins/folder/previewpluginsmodel.cpp
To: broulik, #plasma, #vdg, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180904/128270e3/attachment.html>
More information about the Plasma-devel
mailing list