D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Kai Uwe Broulik]

broulik added a comment.


  I'm not a huge fan of having that notification but if you can assure it doesn't spam the user by showing up repeatedly if a mount is blocked indefinitely, it's fine I guess

INLINE COMMENTS

> soliddeviceengine.cpp:29
>  #include <QDebug>
>  #include <KDiskFreeSpaceInfo>
>  #include <KFormat>

Unused

> soliddeviceengine.cpp:571
> +        // collect and process info
> +        connect(job, &KIO::FileSystemFreeSpaceJob::result,
> +                [this, timer, path, udi](KIO::Job *job, KIO::filesize_t size, KIO::filesize_t available) {

Give `connect` a context:

  connect(job, &KIO::FileSystemFreeSpaceJob::result, this, ...

otherwise it would blow up if we are deleted before the job finishes

> soliddeviceengine.h:38
>  #include "hddtemp.h"
> +#include <KDiskFreeSpaceInfo>
> +#include <KIO/FileSystemFreeSpaceJob>

Unused?

REVISION DETAIL
  https://phabricator.kde.org/D14895

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180904/f319db86/attachment.html>