D15226: Check against QRect whether pointer is inside DecorationButton

David Edmundson noreply at phabricator.kde.org
Mon Sep 3 11:05:15 BST 2018


davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  would adding
  
  bool DecorationButton::contains(QPoint) const
  
  make sense?

INLINE COMMENTS

> decoration.cpp:386
>      for (DecorationButton *button : d->buttons) {
>          if (button->geometry().contains(event->posF())) {
>              QCoreApplication::instance()->sendEvent(button, event);

Missed one

REPOSITORY
  R129 Window Decoration Library

BRANCH
  fix-hover-with-zero-spacing

REVISION DETAIL
  https://phabricator.kde.org/D15226

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180903/388d22d6/attachment.html>


More information about the Plasma-devel mailing list