D15187: Merge switch user dialog into lockscreen

Stefan BrĂ¼ns noreply at phabricator.kde.org
Mon Sep 3 02:01:09 BST 2018


bruns added inline comments.

INLINE COMMENTS

> CMakeLists.txt:47
>  
> +qt5_add_dbus_interface( ksmserver_KDEINIT_SRCS ${KDE_INSTALL_FULL_DBUSINTERFACEDIR}/org.kde.screensaver.xml kscreenlocker_interface )
> +

This breaks in two ways:

- There is no specified dependency on KScreenlocker 5.13.80
- One cannot build easily when dependencies have a different prefix as used for building plasma

The latter needs something like `set(KSCREENLOCKER_DBUS_INTERFACES_DIR "${PACKAGE_PREFIX_DIR}/share/dbus-1/interfaces")
` in KScreenLockerConfig.cmake
This is done by several other components which install DBUS interfaces (Solid, KWallet, Baloo, KNotifications).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15187

To: davidedmundson, #plasma, mart
Cc: bruns, ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180903/02e7111a/attachment.html>


More information about the Plasma-devel mailing list