D16231: [ksmserver] Rewrite Startup

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> apol wrote in startup.cpp:275
> can't this be `&KJob::emitResult`?

It's stupid:

I can do

connect(watch, SIGNAL(finished()), this, SLOT(emitResult()));

but not with function pointers because:

error: 'emitResult' is a protected member of 'KJob'

  connect(watcher, &QDBusPendingCallWatcher::finished, this, &KJob::emitResult);

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16231

To: davidedmundson, #plasma, apol
Cc: apol, broulik, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181030/5cb58340/attachment.html>