D16410: [Bookmarks Runner] Avoid leaking FetchSqlite instances
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Wed Oct 24 19:46:00 BST 2018
bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.
REVISION SUMMARY
The favicon and places instances are created in the prepare() call,
leaking the instance from the last invocation. Delete the old
instance in teardown().
See also T9626 <https://phabricator.kde.org/T9626>.
TEST PLAN
run several queries in krunner
-> instances are no longer leaked
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16410
AFFECTED FILES
runners/bookmarks/browsers/firefox.cpp
To: bruns, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181024/c299585c/attachment.html>
More information about the Plasma-devel
mailing list