D15599: Port the "Switch Desktop" containment action to libtaskmanager
Vlad Zagorodniy
noreply at phabricator.kde.org
Tue Oct 23 09:33:10 BST 2018
zzag added inline comments.
INLINE COMMENTS
> desktop.cpp:58
> } else if (m_actions.count() > numDesktops) {
> - for (int i = numDesktops +1; i <= m_actions.count(); ++i) {
> - delete m_actions[i];
> - m_actions.remove(i);
> + for (int i = m_actions.count(); i >= numDesktops; --i) {
> + delete m_actions.take(i - 1);
It should probably be ">".
If i == numDesktops, we delete numDesktops - 1, which we then access down below.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D15599
To: hein, mart, davidedmundson
Cc: zzag, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181023/97ae9479/attachment.html>
More information about the Plasma-devel
mailing list